Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run watchreact initial build bug #233

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

bjoaquinc
Copy link
Contributor

@bjoaquinc bjoaquinc commented Jan 24, 2025

Description:

Improved the npm run watchreact command:

  • Added code in build.js that checks if src2 directory exists already. If not then it runs the scope-taiwind npx script first to create that folder and its contents before setting up the watchers
  • Removed the text in Contributions.md saying build if it doesn't work

Issue:

Resolves the error that occurs when users run npm run watchreact for the first time. The issue occurs because the watchers are set up at the same time. The second watcher (which uses tsup) fails because it is looking for the src2 directory to watch, which does not exist yet as it is being built for the first time by the other watcher (nodemon).

@andrewpareles andrewpareles merged commit c1123f2 into voideditor:main Jan 29, 2025
@bjoaquinc bjoaquinc deleted the react-build-bug-fix branch January 29, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants